Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrates the security module in the Evse15118D20 module #1030

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Integrates the security module in the Evse15118D20 module #1030

merged 8 commits into from
Feb 4, 2025

Conversation

AssemblyJohn
Copy link
Contributor

@AssemblyJohn AssemblyJohn commented Jan 29, 2025 •
edited
Loading

Describe your changes

  • Adds a connection to the security module in the Evse15118D20 module
  • Obtains certificates/additional info from the security module

Issue ticket number and link

Linked to: EVerest/libiso15118#57

Checklist before requesting a review

  • I have performed a self-review of my code
  • I read the contribution documentation and made sure that my changes meet its requirements
  • I have made corresponding changes to the documentation

@AssemblyJohn AssemblyJohn mentioned this pull request Jan 29, 2025
Merged
3 tasks
@SebaLukas SebaLukas self-assigned this Feb 3, 2025
@AssemblyJohn AssemblyJohn force-pushed the feature/evse15118d20_security_integration branch from a3f0d80 to 6a2ef84 Compare February 3, 2025 14:08
@AssemblyJohn AssemblyJohn marked this pull request as ready for review February 3, 2025 14:09
SebaLukas
SebaLukas approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I added two small comments.
TODO: Updating dependencies.yaml after merging libiso PR

@AssemblyJohn AssemblyJohn force-pushed the feature/evse15118d20_security_integration branch from 6c7e249 to 95cd1c5 Compare February 3, 2025 15:42
@SebaLukas SebaLukas added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Feb 4, 2025
@AssemblyJohn AssemblyJohn force-pushed the feature/evse15118d20_security_integration branch from 95cd1c5 to ad75de7 Compare February 4, 2025 08:29
@SebaLukas
Copy link
Contributor

SebaLukas commented Feb 4, 2025 •
edited
Loading

Before merging, we wait for a libiso release. There is a new libiso release

@AssemblyJohn AssemblyJohn force-pushed the feature/evse15118d20_security_integration branch from c3a7825 to b366e56 Compare February 4, 2025 08:49
@AssemblyJohn
Updated libiso dependency
5991c8a 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn merged commit ffe208b into main Feb 4, 2025
12 checks passed
@AssemblyJohn AssemblyJohn deleted the feature/evse15118d20_security_integration branch February 4, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikinggrass hikinggrass hikinggrass approved these changes

@SebaLukas SebaLukas SebaLukas approved these changes

@a-w50 a-w50 Awaiting requested review from a-w50 a-w50 is a code owner

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen is a code owner

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

Assignees

@SebaLukas SebaLukas

Labels
include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AssemblyJohn @SebaLukas @hikinggrass